Skip to content

Add UI to view and download usage records#8615

Merged
yadvr merged 15 commits intoapache:mainfrom
shapeblue:usage-ui
Jul 30, 2024
Merged

Add UI to view and download usage records#8615
yadvr merged 15 commits intoapache:mainfrom
shapeblue:usage-ui

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Feb 6, 2024 •
edited by DaanHoogland
Loading

Description

This PR adds a new dashboard for viewing and downloading usage records.

This PR also makes startdate and enddate as non required params for generateUsageRecords. (Fixes: #7133)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image
image
image
image
image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 requested a review from shwstppr February 6, 2024 10:33
@blueorangutan
Copy link

blueorangutan commented Feb 6, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.74906% with 265 lines in your changes are missing coverage. Please review.

Project coverage is 31.05%. Comparing base (37bb24f) to head (a4316c9).
Report is 104 commits behind head on main.

Files Patch % Lines
ui/src/views/infra/UsageRecords.vue 0.00% 233 Missing ⚠️
ui/src/utils/util.js 0.00% 14 Missing ⚠️
ui/src/components/view/ListView.vue 0.00% 10 Missing and 1 partial ⚠️
ui/src/components/widgets/Status.vue 0.00% 4 Missing ⚠️
ui/src/views/iam/RolePermissionTab.vue 0.00% 2 Missing ⚠️
ui/src/config/section/tools.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #8615      +/-   ##
============================================
+ Coverage     30.59%   31.05%   +0.45%     
- Complexity    33772    33910     +138     
============================================
  Files          5353     5404      +51     
  Lines        375900   379976    +4076     
  Branches      54629    55425     +796     
============================================
+ Hits         115002   117993    +2991     
- Misses       245710   246348     +638     
- Partials      15188    15635     +447
Flag Coverage Δ
simulator-marvin-tests 24.63% <ø> (+0.39%) ⬆️
uitests 4.31% <0.74%> (-0.07%) ⬇️
unit-tests 16.89% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92
Copy link
Member Author

vishesh92 commented Feb 6, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 6, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@GutoVeronezi GutoVeronezi self-requested a review February 6, 2024 11:25
@blueorangutan
Copy link

blueorangutan commented Feb 6, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8546

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 6, 2024

@blueorangutan test alma9 kvm-alma9 keepEnv

@blueorangutan
Copy link

blueorangutan commented Feb 6, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

shwstppr
shwstppr reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vishesh92!

Some initial comments

@blueorangutan
Copy link

blueorangutan commented Feb 7, 2024

[SF] Trillian test result (tid-9106)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 52074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8615-t9106-kvm-alma9.zip
Smoke tests completed. 121 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_system_vms_metrics_history Failure 0.21 test_metrics_api.py

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 7, 2024

@vishesh92 it seems to me this menu item should be under "tools". what do you think?

@vishesh92
Copy link
Member Author

vishesh92 commented Feb 7, 2024

@vishesh92 it seems to me this menu item should be under "tools". what do you think?

IMO, Tools should have something which contains tools which are used very infrequently and Usage is something someone might use on a regular basis.
I don't have any strong opinions about this, but as of now tools have just Comments & Import-Export Instances. Let me know how should we proceed on this.

image

shwstppr
shwstppr approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Others can comment on the placement of the menu option but I would prefer it under Tools

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 9, 2024

Others can comment on the placement of the menu option but I would prefer it under Tools

metoo

@vishesh92 vishesh92 marked this pull request as ready for review February 14, 2024 12:42
@vishesh92
Copy link
Member Author

vishesh92 commented Feb 14, 2024

@shwstppr @DaanHoogland Moved the menu item to under Tools.

@vishesh92 vishesh92 marked this pull request as draft February 14, 2024 13:12
DaanHoogland
DaanHoogland approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 14, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 14, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 14, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8652

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 15, 2024

@blueorangutan alma9 kvm-alma9 keepEnv

1 similar comment
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 15, 2024

@blueorangutan alma9 kvm-alma9 keepEnv

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 15, 2024

@blueorangutan alma9 kvm-alma9 keepEnv

build started manually, no idea why the bot refuses yet...

@github-actions
Copy link

github-actions bot commented Jul 17, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jul 24, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 24, 2024

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 24, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10452

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jul 24, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 24, 2024

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 25, 2024

[SF] Trillian test result (tid-10957)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 63142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8615-t10957-kvm-centos7.zip
Smoke tests completed. 113 look OK, 24 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_role_account_acls_multiple_mgmt_servers Error 2.29 test_dynamicroles.py
test_query_async_job_result Error 103.94 test_async_job.py
test_revoke_certificate Error 0.02 test_certauthority_root.py
test_configure_ha_provider_invalid Error 0.02 test_hostha_simulator.py
test_configure_ha_provider_valid Error 0.01 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Error 0.01 test_hostha_simulator.py
test_ha_disable_feature_invalid Error 0.01 test_hostha_simulator.py
test_ha_enable_feature_invalid Error 0.01 test_hostha_simulator.py
test_ha_list_providers Error 0.01 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Error 0.01 test_hostha_simulator.py
test_ha_verify_fsm_available Error 0.01 test_hostha_simulator.py
test_ha_verify_fsm_degraded Error 0.01 test_hostha_simulator.py
test_ha_verify_fsm_fenced Error 0.01 test_hostha_simulator.py
test_ha_verify_fsm_recovering Error 0.01 test_hostha_simulator.py
test_hostha_configure_default_driver Error 0.01 test_hostha_simulator.py
test_hostha_configure_invalid_provider Error 0.01 test_hostha_simulator.py
test_hostha_disable_feature_valid Error 0.01 test_hostha_simulator.py
test_hostha_enable_feature_valid Error 0.01 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Error 0.01 test_hostha_simulator.py
test_list_ha_for_host Error 0.01 test_hostha_simulator.py
test_list_ha_for_host_invalid Error 0.01 test_hostha_simulator.py
test_list_ha_for_host_valid Error 0.01 test_hostha_simulator.py
test_01_host_ping_on_alert Error 0.08 test_host_ping.py
test_01_host_ping_on_alert Error 0.08 test_host_ping.py
test_01_browser_migrate_template Error 15.36 test_image_store_object_migration.py
test_01_invalid_upgrade_kubernetes_cluster Failure 238.38 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 229.39 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 259.88 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 214.78 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 230.07 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 244.84 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 341.40 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 236.88 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 84.82 test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version Error 0.13 test_kubernetes_supported_versions.py
login_test_saml_user Error 2.93 test_login.py
test_01_deployVMInSharedNetwork Error 76.21 test_network.py
test_03_destroySharedNetwork Failure 1.07 test_network.py
ContextSuite context=TestSharedNetwork>:teardown Error 2.18 test_network.py
test_oobm_issue_power_cycle Error 3.31 test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off Error 3.31 test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on Error 3.32 test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset Error 3.29 test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft Error 3.31 test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status Error 2.21 test_outofbandmanagement_nestedplugin.py
test_oobm_background_powerstate_sync Failure 21.71 test_outofbandmanagement.py
test_oobm_background_powerstate_sync Error 21.71 test_outofbandmanagement.py
test_oobm_configure_default_driver Error 0.07 test_outofbandmanagement.py
test_oobm_configure_invalid_driver Error 0.06 test_outofbandmanagement.py
test_oobm_disable_feature_invalid Error 0.05 test_outofbandmanagement.py
test_oobm_disable_feature_valid Error 1.15 test_outofbandmanagement.py
test_oobm_enable_feature_invalid Error 0.04 test_outofbandmanagement.py
test_oobm_enable_feature_valid Error 1.10 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 11.82 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 11.82 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 4.35 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 4.35 test_outofbandmanagement.py
test_oobm_issue_power_off Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_off Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_on Error 4.36 test_outofbandmanagement.py
test_oobm_issue_power_on Error 4.36 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 4.33 test_outofbandmanagement.py
test_oobm_issue_power_status Error 4.36 test_outofbandmanagement.py
test_oobm_issue_power_status Error 4.36 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Error 1.13 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Error 1.13 test_outofbandmanagement.py
test_oobm_zchange_password Error 2.22 test_outofbandmanagement.py
test_oobm_zchange_password Error 2.22 test_outofbandmanagement.py
test_02_edit_primary_storage_tags Error 0.02 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.08 test_primary_storage_scope.py
test_01_vpc_privategw_acl Error 0.03 test_privategw_acl_ovs_gre.py
test_03_vpc_privategw_restart_vpc_cleanup Error 0.02 test_privategw_acl_ovs_gre.py
test_05_vpc_privategw_check_interface Error 0.02 test_privategw_acl_ovs_gre.py
test_01_vpc_privategw_acl Error 54.58 test_privategw_acl.py
test_02_vpc_privategw_static_routes Error 213.28 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Error 225.47 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Error 359.50 test_privategw_acl.py
test_01_purge_expunged_api_vm_start_date Error 49.68 test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date Error 45.31 test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date Error 48.36 test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date Error 49.16 test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering Error 271.12 test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task Error 335.33 test_purge_expunged_vms.py
test_01_snapshot_root_disk Error 3.28 test_snapshots.py
test_CreateTemplateWithDuplicateName Error 18.73 test_templates.py
test_01_register_template_direct_download_flag Error 0.17 test_templates.py
test_01_positive_tests_usage Error 10.41 test_usage_events.py
test_01_ISO_usage Error 1.09 test_usage.py
test_01_lb_usage Error 6.27 test_usage.py
test_01_nat_usage Error 8.34 test_usage.py
test_01_public_ip_usage Error 1.07 test_usage.py
test_01_snapshot_usage Error 37.92 test_usage.py
test_01_template_usage Error 9.37 test_usage.py
test_01_vm_usage Error 134.92 test_usage.py
test_01_volume_usage Error 124.86 test_usage.py
test_01_vpn_usage Error 10.50 test_usage.py
test_03_secured_to_nonsecured_vm_migration Error 394.59 test_vm_life_cycle.py
test_12_start_vm_multiple_volumes_allocated Error 10.57 test_vm_life_cycle.py
test_01_vmschedule_create Error 0.09 test_vm_schedule.py
test_disable_oobm_ha_state_ineligible Error 0.06 test_hostha_kvm.py
test_hostha_configure_default_driver Error 0.04 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled Error 0.04 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected Error 0.04 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 0.04 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 0.04 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 0.04 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 0.05 test_hostha_kvm.py
test_remove_ha_provider_not_possible Error 0.06 test_hostha_kvm.py

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jul 25, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 25, 2024

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 25, 2024

[SF] Trillian test result (tid-10961)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53444 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8615-t10961-kvm-centos7.zip
Smoke tests completed. 135 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 339.23 test_purge_expunged_vms.py
test_02_redundant_VPC_default_routes Failure 383.89 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 405.59 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 516.41 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 516.43 test_vpc_redundant.py

@github-actions
Copy link

github-actions bot commented Jul 26, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@vishesh92
Copy link
Member Author

vishesh92 commented Jul 29, 2024

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 29, 2024

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 29, 2024

UI build failed: ✖️
(SL-JID-412)

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jul 29, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 29, 2024

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 29, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10504

@vishesh92
Copy link
Member Author

vishesh92 commented Jul 30, 2024

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 30, 2024

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

borisstoyanov
borisstoyanov approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Member

yadvr commented Jul 30, 2024

Merging based on review and manual QA. LGTM.

@yadvr yadvr merged commit 5baac44 into apache:main Jul 30, 2024
@yadvr yadvr deleted the usage-ui branch July 30, 2024 09:08
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 31, 2024
@vishesh92 @dhslove
ui: add UI too to view and download usage records (apache#8615)
ec7c360 
This PR adds a new UI tool for admins for viewing and downloading usage records.

This PR also makes startdate and enddate as non required params for generateUsageRecords. (Fixes: apache#7133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardodemarco bernardodemarco bernardodemarco left review comments

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

Assignees

No one assigned

Labels

component:api component:UI

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

generateUsageRecords does not work

8 participants

@vishesh92 @blueorangutan @DaanHoogland @yadvr @codecov-commenter @borisstoyanov @shwstppr @bernardodemarco